Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set -Wno-deprecated-gpu-targets when compiling for RAPIDS architectures #776

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Set -Wno-deprecated-gpu-targets when compiling for RAPIDS architectures #776

merged 3 commits into from
Feb 22, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 11, 2025

Description

Closes #761.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner February 11, 2025 14:42
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 11, 2025
@bdice bdice self-assigned this Feb 11, 2025
@bdice bdice changed the title Set -Wno-deprecated-gpu-targets when compiling for RAPIDS architectures Set -Wno-deprecated-gpu-targets when compiling for RAPIDS architectures Feb 11, 2025
@vyasr
Copy link
Contributor

vyasr commented Feb 14, 2025

@robertmaynard do we need to do any further testing of this or are you good with merging it as-is?

@robertmaynard
Copy link
Contributor

@robertmaynard do we need to do any further testing of this or are you good with merging it as-is?

It is now ready

bdice
bdice commented Feb 22, 2025
View reviewed changes
Copy link
Contributor Author

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robertmaynard -- I approve your changes, so I will merge this. We can let nightlies rebuild the sccache over the weekend.

@bdice
Copy link
Contributor Author

bdice commented Feb 22, 2025

/merge

@rapids-bot rapids-bot bot merged commit b01af45 into rapidsai:branch-25.04 Feb 22, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard left review comments

@vyasr vyasr vyasr approved these changes

Assignees

@bdice bdice

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporarily add "-Wno-deprecated-gpu-targets" to set_runtime
3 participants
@bdice @vyasr @robertmaynard